[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 12 Dec 2006 17:24:39 +0100
From: Adrian Bunk <bunk@...sta.de>
To: Jay Vosburgh <fubar@...ibm.com>
Cc: Jeff Garzik <jeff@...zik.org>, ctindel@...rs.sourceforge.net,
bonding-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: [2.6 patch] bonding.h: "extern inline" -> "static inline"
"extern inline" generates a warning with -Wmissing-prototypes and I'm
currently working on getting the kernel cleaned up for adding this to
the CFLAGS since it will help us to avoid a nasty class of runtime
errors.
If there are places that really need a forced inline, __always_inline
would be the correct solution.
Signed-off-by: Adrian Bunk <bunk@...sta.de>
---
drivers/net/bonding/bonding.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.19-mm1/drivers/net/bonding/bonding.h.old 2006-12-12 15:57:43.000000000 +0100
+++ linux-2.6.19-mm1/drivers/net/bonding/bonding.h 2006-12-12 15:58:17.000000000 +0100
@@ -237,12 +237,13 @@
#define BOND_ARP_VALIDATE_ALL (BOND_ARP_VALIDATE_ACTIVE | \
BOND_ARP_VALIDATE_BACKUP)
-extern inline int slave_do_arp_validate(struct bonding *bond, struct slave *slave)
+static inline int slave_do_arp_validate(struct bonding *bond,
+ struct slave *slave)
{
return bond->params.arp_validate & (1 << slave->state);
}
-extern inline u32 slave_last_rx(struct bonding *bond, struct slave *slave)
+static inline u32 slave_last_rx(struct bonding *bond, struct slave *slave)
{
if (slave_do_arp_validate(bond, slave))
return slave->last_arp_rx;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists