lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Dec 2006 15:50:57 -0800 From: Stephen Hemminger <shemminger@...l.org> To: Andrew Morton <akpm@...l.org> Cc: benjamin.li@...gic.com, "bugme-daemon@...nel-bugs.osdl.org" <bugme-daemon@...zilla.kernel.org>, netdev@...r.kernel.org Subject: Re: [Bugme-new] [Bug 7708] New: unregister_netdev() should return unregister_netdevice() return code On Mon, 18 Dec 2006 15:21:11 -0800 Andrew Morton <akpm@...l.org> wrote: > On Mon, 18 Dec 2006 14:56:31 -0800 > bugme-daemon@...zilla.kernel.org wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=7708 > > > > Summary: unregister_netdev() should return unregister_netdevice() > > return code > > Kernel Version: 2.6.19.1 > > Status: NEW > > Severity: low > > Owner: acme@...ectiva.com.br > > Submitter: benjamin.li@...gic.com > > > > > > net/core/dev.c:unregister_netdev() function is a wrapper around > > net/core/dev.c:unregister_netdevice(). The unregister_netdevice() function > > returns a return code while unregister_netdev() currently does not. For > > completeness, we should pass the return code from unregister_netdevice() all the > > way to the caller. unregister_netdev() should not swallow the return code. > > > > Certainly there's some truth in that ;) > > Is there some reason why you want to test the unregister_netdev() return > value? The only return value is -ENODEV, so I would vote for both just being void -- Stephen Hemminger <shemminger@...l.org> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists