netdev - Re: [PATCH 0/5] qla3xxx:resubmit support for Qlogic 4032 and fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Dec 2006 16:34:27 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	ron.mercer@...gic.com
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/5] qla3xxx:resubmit support for Qlogic 4032 and fixes.

Ron Mercer wrote:
> These 5 patches were submitted on Dec 5th (1&2) and Dec 11th (3-5).  They add/fix the following
> 
> 1. Add support for Qlogic 4032 chip.
> 2. Change minor version for 4032 support.
> 3. Add delay when accessing NVRAM.
> 4. Remove NETIF_F_LLTX flag from features.  It was left over from the early driver and shouldn't be there.
> 5. Fix rx checksum warning.
> 
> We didn't get any feedback on any of these previously posted patches and couldn't find a tree where they were added.  We've build and tested them on 2.6.20-rc1.
> 
> These patches must be applied in order.

Please:

1) Fix your Mail-Followup-To header, so that it doesn't cause CC's to be 
trimmed.

2) Re-order the patches so that bug fixes come first.  Otherwise this 
entire patchset must go into netdev-2.6.git#upstream, because patch #1 
is not a bug fix and we are in a bug-fixes-only cycle.

3) Regarding patch #3:  have you verified that a missing PCI flush was 
not the cause of your problems?  It seems like udelay(1) could be removed?

ACK the other stuff

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html