netdev - d80211 constants inside d80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Dec 2006 10:32:52 +0200
From:	"Nick Kossifidis" <mickflemm@...il.com>
To:	netdev@...r.kernel.org
Cc:	"David Kimdon" <david.kimdon@...icescape.com>,
	linville@...driver.com, jbenc@...e.cz
Subject: d80211 constants inside d80211_common.h

ieee80211_msg_type, ieee80211_phytype and ieee80211_ssi_type should be
in capitals as they are constants and must not be mistaken for vars...


enum ieee80211_msg_type {
        IEEE80211_MSG_NORMAL            = 0,
        IEEE80211_MSG_TX_CALLBACK_ACK   = 1,
        IEEE80211_MSG_TX_CALLBACK_FAIL  = 2,
        IEEE80211_MSG_PASSIVE_SCAN      = 3,
        IEEE80211_MSG_WEP_FRAME_UNKNOWN_KEY = 4,
        IEEE80211_MSG_MICHAEL_MIC_FAIL  = 5,
        /* hole at 6, was monitor but never sent to userspace */
        IEEE80211_MSG_STA_NOT_ASSOC     = 7,
        IEEE80211_MSG_SET_AID_FOR_STA   = 8 /* used by Intersil MVC driver */,
        IEEE80211_MSG_KEY_THRESHOLD_NOTIFICATION = 9,
        IEEE80211_MSG_RADAR             = 11,
};


enum ieee80211_phytype {
        IEEE80211_PHYTYPE_FHSS_DOT11_97  = 1,
        IEEE80211_PHYTYPE_DSSS_DOT11_97  = 2,
        IEEE80211_PHYTYPE_IRBASEBAND     = 3,
        IEEE80211_PHYTYPE_DSSS_DOT11_B   = 4,
        IEEE80211_PHYTYPE_PBCC_DOT11_B   = 5,
        IEEE80211_PHYTYPE_OFDM_DOT11_G   = 6,
        IEEE80211_PHYTYPE_PBCC_DOT11_G   = 7,
        IEEE80211_PHYTYPE_OFDM_DOT11_A   = 8,
        IEEE80211_PHYTYPE_DSSS_DOT11_TURBOG = 255,
        IEEE80211_PHYTYPE_DSSS_DOT11_TURBO = 256,
};


enum ieee80211_ssi_type {
        IEEE80211_SSI_NONE = 0,
        IEEE80211_SSI_NORM = 1, /* normalized, 0-1000 */
        IEEE80211_SSI_DBM = 2,
        IEEE80211_SSI_RAW = 3, /* raw SSI */
};

I did a grep inside drivers/net/wireless/d80211/* and they are not
used yet in drivers. Can you plz fix it before drivers start using
them ?


Thanx for your time
Nick
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html