lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Jan 2007 08:47:48 +0100 From: "Daniel Marjamäki" <daniel.marjamaki@...il.com> To: "David Miller" <davem@...emloft.net> Cc: netdev@...r.kernel.org, kernel-janitors@...ts.osdl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net/core/flow.c: compare data with memcmp Hello! So you mean that in this particular case it's faster with a handcoded comparison than memcmp? Because both key1 and key2 are located at word-aligned addresses? That's fascinating. Best regards, Daniel 2006/12/31, David Miller <davem@...emloft.net>: > From: "Daniel_Marjamäki" <daniel.marjamaki@...il.com> > Date: Sun, 31 Dec 2006 17:37:05 +0100 > > > From: Daniel Marjamäki > > This has been tested by me. > > Signed-off-by: Daniel Marjamäki <daniel.marjamaki@...il.com> > > Please do not do this. > > memcmp() cannot assume the alignment of the source and > destination buffers and thus will run more slowly than > that open-coded comparison. > > That code was done like that on purpose because it is > one of the most critical paths in the networking flow > cache lookup which runs for every IPSEC packet going > throught the system. > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists