netdev - Re: [PATCH] [IPVS] replace if .. goto with while

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Jan 2007 22:37:51 +0900
From:	Horms <horms@...ge.net.au>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, wensong@...ux-vs.org, ja@....bg,
	ratz@...gphish.ch, jmack@...d.net
Subject: Re: [PATCH] [IPVS] replace if .. goto with while

On Tue, Jan 02, 2007 at 12:38:39AM -0800, David Miller wrote:
> From: Horms <horms@...ge.net.au>
> Date: Mon, 18 Dec 2006 12:11:11 +0900
> 
> > I guess that this code used to be more complex, but replacing
> > the goto with a while seems to make things a bit more readable.
> > Or in other words, two fairly gratuitous goto are removed.
> > 
> > On a related note, I wonder if there should be a limit to how
> > many times it tries.
> > 
> > Signed-Off-By: Simon Horman <horms@...ge.net.au>
> 
> Yes, there should be, something like a limit of one. :-)
> 
> There is no reason to loop on something like this, just
> return a failure immediately if creating the kernel thread
> fails.

Will do.

> As a side note, if it's easy you might want to convert this
> over the the include/linux/kthread.h interfaces.  I just did
> this for pktgen tonight and it cleaned a lot of stuff up.

Thanks, I will look into it.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html