| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Jan 2007 15:23:07 -0500 From: Pavel Roskin <proski@....org> To: Jiri Benc <jbenc@...e.cz> Cc: netdev@...r.kernel.org Subject: Re: d80211: a patch for standalone d80211 tarball Hi, Jiri! On Mon, 2007-01-29 at 18:48 +0100, Jiri Benc wrote: > +#define register_invisible_netdevice register_netdevice > +#define unregister_invisible_netdevice unregister_netdevice Please use macros with arguments whenever possible. This way, incorrect macro invocations would be detected even if the original prototype is missing. Also, the macro name could be used without arguments for other purposes (variable, gcc attribute etc). Both cases are highly unlikely for the above macros, but please keep in mind that some aspiring programmers view the kernel as an example of good programming style. -- Regards, Pavel Roskin - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists