netdev - Re: [PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 30 Jan 2007 09:41:32 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Jay Cliburn <jacliburn@...lsouth.net>
CC:	csnook@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, atl1-devel@...ts.sourceforge.net,
	randy.dunlap@...cle.com, kronos.it@...il.com
Subject: Re: [PATCH 2.6.20-rc5 1/4] atl1: unconditionally enable MSI

Jay Cliburn wrote:
> From: Luca Tettamanti <kronos.it@...il.com>
> 
> Unconditionally enable MSI in atl1 driver. Also remove some useless
> #ifdef since pci_{en,dis}able_msi() are no-op when MSI support is not
> configured in.
> 
> Signed-off-by: Luca Tettamanti <kronos.it@...il.com>
> Signed-off-by: Jay Cliburn <jacliburn@...lsouth.net>

applied patches 1-4 to #atl1

The only remaining problem with your patches is that they added trailing 
whitespace:

[jgarzik@...tzel netdev-2.6]$ git-am --signoff --utf8 /g/tmp/mbox

Applying 'atl1: unconditionally enable MSI'

Adds trailing whitespace.
.dotest/patch:44:
warning: 1 line adds trailing whitespaces.
Wrote tree dc738e9c0b8becc628dc3bdbbcb02988b671065a
Committed: ab248491d6e576228710950e3d21ea0731aa2de4

Applying 'atl1: add missing include dma-mapping.h'

Wrote tree 5fb3cad9771ccb59d7e3610367bb69bb33b3b45d
Committed: 13b6ae2c23523e808530681e16998220150c881c

Applying 'atl1: properly use CONFIG_PM'

Wrote tree 9fb334ce776443d59039aaedcd6a5a09790a3d67
Committed: 01e8d5606f0732222baf9ec8664d1e833ac428ca

Applying 'atl1: incorporate reviewer comments'

Adds trailing whitespace.
.dotest/patch:197:static int atl1_get_settings(struct net_device *netdev,
Adds trailing whitespace.
.dotest/patch:230:static int atl1_set_settings(struct net_device *netdev,
Adds trailing whitespace.
.dotest/patch:240:              printk(KERN_DEBUG "%s: ethtool shutting 
down adapter\n",
Adds trailing whitespace.
.dotest/patch:258:                      } else
Adds trailing whitespace.
.dotest/patch:292:
warning: squelched 10 whitespace errors
warning: 15 lines add trailing whitespaces.
Wrote tree 75ab9e0e86a96951c542b1f6e7557c917ca6799b
Committed: 37e12a2bd50cb62add05b97fc6661d21782f232b

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html