lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 01 Feb 2007 13:40:35 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: romieu@...zoreil.com (Francois Romieu) Cc: torvalds@...ux-foundation.org, netdev@...r.kernel.org, akpm@...l.org, jgarzik@...ox.com, bwalle@...e.de Subject: Re: [PATCH] r8169: fix a race between PCI probe and dev_open Francois Romieu <romieu@...zoreil.com> wrote: > > rtl8169_init_phy is only used on rtl8169_init_one so it's fine to never > ask it to activate the timer: the racing dev->open will do it anyway. Does rtl8169_init_phy need to occur after register_netdev? Normally register_netdev should be the very last thing in a probe routine. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists