netdev - Re: [RFC][PATCH][XFRM][1/5] extension to XFRM for dynamic endpoint update (MIGRATE)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Feb 2007 07:51:14 -0500 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Shinta Sugimoto <shinta@....wide.ad.jp>
cc:	netdev@...r.kernel.org, Francis Dupont <Francis.Dupont@...nt6.net>,
	Masahide Nakamura <nakam@...ux-ipv6.org>,
	usagi-core@...ux-ipv6.org
Subject: Re: [RFC][PATCH][XFRM][1/5] extension to XFRM for dynamic endpoint
 update (MIGRATE)

On Fri, 2 Feb 2007, Shinta Sugimoto wrote:

> > 
> > > +EXPORT_SYMBOL(xfrm_state_clone);
> > 
> > Why not EXPORT_SYMBOL_GPL ?
> > (for all of your exports).
> 
> Actually I don't have specific preference on either EXPORT_SYMBOL or
> EXPORT_SYMBOL_GPL.  It seemed to me that other functions defined in
> files under net/xfrm/ are using EXPORT_SYMBOL, so I followed that.

Hmm, you're right, most of them are not _GPL.

> Do you think EXPORT_SYMBOL_GPL is more appropriate in this case?

Well, I would have thought that users of xfrm were generally derivative of 
the kernel, but it doesn't make much sense to have only a couple of 
symbols exported as GPL, so probably keep it the way you already have it.


- James
-- 
James Morris
<jmorris@...ei.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html