netdev - Re: [PATCH] ieee80211: Fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 02 Feb 2007 15:38:09 -0600
From:	Larry Finger <larry.finger@...inger.net>
To:	"John W. Linville" <linville@...driver.com>
CC:	Michael Buesch <mb@...sch.de>, netdev@...r.kernel.org,
	Bcm43xx-dev@...ts.berlios.de
Subject: Re: [PATCH] ieee80211: Fix sparse warning

John W. Linville wrote:
> On Wed, Jan 31, 2007 at 06:50:19PM -0600, Larry Finger wrote:
>> Sparse issues the warning "warning: symbol 'crypt' shadows an earlier one"
>> in net/ieee80211/ieee80211_tx.c.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
>> ---
>>
>> Index: wireless-2.6/net/ieee80211/ieee80211_tx.c
>> ===================================================================
>> --- wireless-2.6.orig/net/ieee80211/ieee80211_tx.c
>> +++ wireless-2.6/net/ieee80211/ieee80211_tx.c
>> @@ -502,8 +502,6 @@ int ieee80211_xmit(struct sk_buff *skb, 
>>  		if (host_encrypt)
>>  			ieee80211_encrypt_fragment(ieee, skb_frag, hdr_len);
>>  		else if (host_build_iv) {
>> -			struct ieee80211_crypt_data *crypt;
>> -
>>  			crypt = ieee->crypt[ieee->tx_keyidx];
>>  			atomic_inc(&crypt->refcnt);
>>  			if (crypt->ops->build_iv)
> 
> Couldn't you remove the "crypt = ieee->crypt[ieee->tx_keyidx];"
> as well?

Yes it can. I'll send a revised patch along shortly.

Larry
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html