lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Feb 2007 11:12:07 +0200 From: "Ahmed S. Darwish" <darwish.07@...il.com> To: Alexey Dobriyan <adobriyan@...il.com> Cc: ebs@...home.net, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linuxppc-embedded@...abs.org Subject: Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate On Mon, Feb 05, 2007 at 11:22:06PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote: > > A patch to use ARRAY_SIZE macro already defined in kernel.h. > > OK, but checks you're changing are strange. idx there is signed so > > BUG_ON(idx < 0 || idx > ARRAY_SIZE()); > > should be more appropriate. It's just a janitor patch. I don't like to mess with code logic in such kind of patches (to minimize errors and because I can't find time to understand all affected files since they are scattered allover the tree). Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists