netdev - Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 09 Feb 2007 12:31:23 +0000
From:	David Howells <dhowells@...hat.com>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Cc:	dhowells@...hat.com, davem@...emloft.net, netdev@...r.kernel.org,
	herbert.xu@...hat.com, hch@...radead.org, arjan@...radead.org
Subject: Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation 

YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org> wrote:

> and make it sure to align on 64-bit word.

The first part of sockaddr_rxrpc is exactly 64 bits; then comes the transport
address, so that's okay.

> This sockaddr_rxrpc{} should NOT include sockaddr_in{} directly.
> Please use sockaddr_storage{} (or sockaddr{}, maybe),

Why can't I include sockaddr_in and sockaddr_in6 in sockaddr_rxrpc, btw?

> > That won't work.  That would then make the address larger than the maximum
> > size (ie: sizeof(struct sockaddr_storage)).
> 
> sockaddr{}, then...

But that's not big enough to hold a sockaddr_in6...

David
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html