netdev - RE: [TIPC] Missing null check in the socket code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Feb 2007 09:02:37 -0500
From:	"Jon Maloy \(QB/EMC\)" <jon.maloy@...csson.com>
To:	"Max Krasnyansky" <maxk@...lcomm.com>, <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>, <allan.stephens@...driver.com>
Subject: RE: [TIPC] Missing null check in the socket code.

Acknowledged. We'll deliver it along with 
some other patches ASAP.

///jon


-----Original Message-----
From: Max Krasnyansky [mailto:maxk@...lcomm.com]
Sent: Tue 2/20/2007 1:48 PM
To: davem@...emloft.net
Cc: netdev@...r.kernel.org; Jon Maloy (QB/EMC); allan.stephens@...driver.com
Subject: Re: [TIPC] Missing null check in the socket code.
 
Max Krasnyansky wrote:
> Fixes an oops in the non-blocking mode.
> 
> Signed-off-by: Max Krasnyansky <maxk@...lcomm.com>
> ---
>  net/tipc/socket.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index 2a6a5a6..767f791 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -862,6 +862,10 @@ restart:
>  	/* Get access to first message in receive queue */
>  
>  	buf = skb_peek(&sock->sk->sk_receive_queue);
> +	if (NULL == buf) {
> +		res = -EAGAIN;
> +		goto exit;
> +	}
>  	msg = buf_msg(buf);
>  	sz = msg_data_sz(msg);
>  	err = msg_errcode(msg);

Just a reminder. Please apply.

Thanx
Max

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html