netdev - Re: [PATCH 2/2][TCP] YeAH-TCP: limited slow start exported function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Feb 2007 00:21:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	angelo.castellani@...il.com
Cc:	netdev@...r.kernel.org, andrea.baiocchi@...roma1.it,
	francesco@....infocom.uniroma1.it
Subject: Re: [PATCH 2/2][TCP] YeAH-TCP: limited slow start exported function

From: "Angelo P. Castellani" <angelo.castellani@...il.com>
Date: Mon, 19 Feb 2007 11:35:09 +0100

> From: Angelo P. Castellani <angelo.castellani@...il.con>
> 
> RFC3742: limited slow start
> 
> See http://www.ietf.org/rfc/rfc3742.txt
> 
> Signed-off-by: Angelo P. Castellani <angelo.castellani@...il.con>
> ---
> 
> To allow code reutilization I've added the limited slow start procedure 
> as an exported symbol of linux tcp congestion control.
> 
> On large BDP networks canonical slow start should be avoided because it 
> requires large packet losses to converge, whereas at lower BDPs slow 
> start and limited slow start are identical. Large BDP is defined through 
> the max_ssthresh variable.
> 
> I think limited slow start could safely replace the canonical slow start 
> procedure in Linux.
 ...
> p.s.: in the attached patch is added an exported function currently used 
> only by YeAH TCP

Please never submit patches like this, submit the infrastructure
FIRST, then submit the stuff that uses it.  When a sequence of patches
is applied, in sequence, the tree should build properly (even with all
available new options enabled) at each step along the way.

Otherwise we have the situation we have now, in that YeaH is in my
tree but doesn't build successfully.

What I'm going to do to "fix" this, is yank YeaH implementation out
of my tree, add this second patch first, then add the YeaH patch
back.

Please never do this again.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html