[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 28 Feb 2007 08:05:13 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: Daniel Lezcano <dlezcano@...ibm.com>
Cc: netdev@...r.kernel.org, containers@...ts.osdl.org,
openib-general@...nib.org
Subject: Re: [PATCH RFC 22/31] net: Add network namespace clone support.
Daniel Lezcano <dlezcano@...ibm.com> writes:
>> +
>> + mutex_lock(&net_mutex);
>> + err = setup_net(new_net);
>> + if (err)
>> + goto out_unlock;
>>
> Should we "net_free" in case of error ?
Oops. Yes we should.
Thanks.
>> + net_lock();
>> + net_list_append(new_net);
>> + net_unlock();
>> +
>> + tsk->nsproxy->net_ns = new_net;
>> +
>> +out_unlock:
>> + mutex_unlock(&net_mutex);
net_free(new_net);
>> +out:
>> + put_net(old_net);
>> + return err;
>> +}
>> +
>>
Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists