netdev - Re: s390 allmodconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Mar 2007 11:38:24 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	"John W. Linville" <linville@...driver.com>,
	Michael Buesch <mb@...sch.de>,
	Richard Purdie <rpurdie@...ys.net>, netdev@...r.kernel.org
Subject: Re: s390 allmodconfig

On Fri, 2007-03-02 at 00:25 -0800, Andrew Morton wrote:

> Probably related to the Kconfig problems.

Yeah, it is. s390 is funny, it doesn't include drivers/Kconfig, I don't
think anybody of us would have suspected that.

There doesn't seem to be a reason why it shouldn't have drivers/leds
though. drivers/ssb I don't know about, does s390 have pci or pcmcia?
And the bluetooth stuff is also plain weird, I suppose s390 really
should include drivers/hid/Kconfig :)

Same with drivers/char that includes hw_random.

Is there any reason it isn't including drivers/Kconfig? 

I can offer below patch to fix the LED trigger problem, it's probably
cleaner to depend on LEDS_TRIGGERS rather than selecting it and
NEW_LEDS.

johannes

--- wireless-dev.orig/net/mac80211/Kconfig	2007-03-02 11:18:45.464333268 +0100
+++ wireless-dev/net/mac80211/Kconfig	2007-03-02 11:33:24.534333268 +0100
@@ -13,9 +13,7 @@ config MAC80211

 config MAC80211_LEDS
 	bool "Enable LED triggers"
-	depends on MAC80211
-	select NEW_LEDS
-	select LEDS_TRIGGERS
+	depends on MAC80211 && LEDS_TRIGGERS
 	---help---
 	This option enables a few LED triggers for different
 	packet receive/transmit events.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html