[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 02 Mar 2007 20:23:06 -0500
From: Jeff Garzik <jeff@...zik.org>
To: Shan Lu <shanlu@...uiuc.edu>
CC: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, shanlu@...c.edu
Subject: Re: [patch 1/1] network: add the missing phy_device speed information
to phy_mii_ioctl
Shan Lu wrote:
> Changelog:
> Function `phy_mii_ioctl' returns physical device's information based on
> user requests. When requested to return the basic mode control register
> information (BMCR), the original implementation only returns the
> physical device's duplex information and forgets to return speed
> information, which should not be because BMCR register is used to hold
> both duplex and speed information.
>
> The patch checks the BMCR value against speed-related flags and fills
> the return structure's speed field accordingly.
>
> Signed-off-by: Shan<shanlu@...uiuc.edu>
>
> ---
> --- drivers/net/phy/phy.c 2007-03-02 10:40:26.000000000 -0600 2.6.20
> +++ drivers/net/phy/phy.c 2007-03-02 10:41:39.000000000 -0600
> @@ -337,6 +337,10 @@ int phy_mii_ioctl(struct phy_device *phy
> phydev->duplex = DUPLEX_FULL;
> else
> phydev->duplex = DUPLEX_HALF;
> + if ((!phydev->autoneg) && (val
> &BMCR_SPEED1000))
> + phydev->speed = SPEED_1000;
> + else if ((!phydev->autoneg) && (val &
> BMCR_SPEED100))
> + phydev->speed = SPEED_100;
patch is word-wrapped
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists