netdev - Re: compat_sock_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Mar 2007 09:43:05 -0500 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Johannes Berg <johannes@...solutions.net>
cc:	netdev <netdev@...r.kernel.org>
Subject: Re: compat_sock_common_getsockopt typo?

On Tue, 6 Mar 2007, Johannes Berg wrote:

> The function reads as follows:
> 
> int compat_sock_common_getsockopt(struct socket *sock, int level, int optname,
>                                   char __user *optval, int __user *optlen)
> {
>         struct sock *sk = sock->sk;
> 
>         if (sk->sk_prot->compat_setsockopt != NULL)
>                                 ^^^
> 
>                 return sk->sk_prot->compat_getsockopt(sk, level, optname,
>                                            ^^^
>                                                       optval, optlen);
>         return sk->sk_prot->getsockopt(sk, level, optname, optval, optlen);
> }
> EXPORT_SYMBOL(compat_sock_common_getsockopt);
> 
> Is that intentional to make protocol writers assign both if they want
> compat_setsockopt? :P

It's a bug.



-- 
James Morris
<jmorris@...ei.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html