netdev - Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Mar 2007 16:05:13 -0800 (PST)
From:	Giridhar Pemmasani <pgiri@...oo.com>
To:	Dale Farnsworth <dale@...nsworth.org>, akpm@...ux-foundation.org
Cc:	jeff@...zik.org, netdev@...r.kernel.org, giri@....cs.sunysb.edu,
	pgiri@...oo.com
Subject: Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix


--- Dale Farnsworth <dale@...nsworth.org> wrote:

> On Tue, Mar 06, 2007 at 02:42:02AM -0800, akpm@...ux-foundation.org wrote:
> > From: Giridhar Pemmasani <giri@....cs.sunysb.edu>
> > 
> > During initialization, mv643xx driver registers IRQ before setting up
> tx/rx
> > rings.  This causes kernel oops because mv643xx_poll, which gets called
> > right after registering IRQ, calls netif_rx_complete, which accesses the
> rx
> > ring (I don't have the oops message anymore; I just remember this
> sequence
> > of calls).  Attached (tested) patch first initializes the rx/tx rings and
> > then registers the IRQ.
> 
> I believe a better fix is to disable any pending interrupt sources
> before calling request_irq().  I sent the patch below to Giri for
> confirmation, but haven't heard back.  I should've copied Andrew.
> 
> Giri, have you had a chance to test this alternative patch?

I got a chance to test this patch today. I can confirm that this patch fixes
the issue reported.

Thanks,
Giri


 
____________________________________________________________________________________
The fish are biting. 
Get more visitors on your site using Yahoo! Search Marketing.
http://searchmarketing.yahoo.com/arp/sponsoredsearch_v2.php
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html