netdev - Re: Oops in filter add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Mar 2007 18:06:13 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Chris Madden <chris@...lexsecurity.com>
CC:	Thomas Graf <tgraf@...g.ch>, hadi@...erus.ca,
	netdev@...r.kernel.org
Subject: Re: Oops in filter add

Chris Madden wrote:
> Patrick McHardy wrote:
> 
>>There was a small bug in my patch (broken return value on memory
>>allocation failure, not relevant for testing though). I'll push
>>the fixed patch to Dave once Chris confirms that it fixes the
>>problem he's seeing.
>>  
> 
> Looks like that may have done it.  I ramped up the traffic on it and did
> thousands of inserts/removals and the box seems happy.


Thanks Chris.

> I had ing_filter still locking dev->ingress_lock ( instead of the
> queue_lock suggestion earlier ).   So while that race may still be in
> there, I haven't been able to hit the locking problem.


I'll push a patch for this as well, we can hopefully go back to using
ingress_lock in 2.6.22.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html