netdev - Re: [NET_SCHED 11/11]: qdisc: avoid dequeue while throttled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Mar 2007 15:39:42 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	davem@...emloft.net
CC:	netdev@...r.kernel.org
Subject: Re: [NET_SCHED 11/11]: qdisc: avoid dequeue while throttled

Patrick McHardy wrote:
> [NET_SCHED]: qdisc: avoid dequeue while throttled

It just occured to me that this doesn't work properly with qdiscs
that have multiple classes since they all don't properly maintain
the TCQ_F_THROTTLED flag. They set it on dequeue when no active
class is willing to give out packets, but when enqueueing to a
non-active class (thereby activating it) it is still set even though
we don't know if that class could be dequeued.

So this updated patch unsets the TCQ_F_THROTTLED flag whenever we
activate a class. Additionally it removes the unsetting of
TCQ_F_THROTTLED on successful dequeue since we're now guaranteed
that it was not set before.

View attachment "11.diff" of type "text/x-diff" (4395 bytes)