netdev - RE: [PATCH] NAPI support for Sibyte MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2007 14:33:57 -0700
From:	"Mark E Mason" <mason@...adcom.com>
To:	"Sergei Shtylyov" <sshtylyov@...mvista.com>
cc:	linux-mips@...ux-mips.org, netdev@...r.kernel.org
Subject: RE: [PATCH] NAPI support for Sibyte MAC

Hello, 

> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov@...mvista.com] 
> Sent: Saturday, March 24, 2007 12:49 PM
> To: Mark E Mason
> Cc: linux-mips@...ux-mips.org; netdev@...r.kernel.org
> Subject: Re: [PATCH] NAPI support for Sibyte MAC

[snip]
> > @@ -2075,12 +2143,52 @@
> >  		 */
> >  
> >  		if (isr & (M_MAC_INT_CHANNEL << S_MAC_TX_CH0)) {
> > -			sbdma_tx_process(sc,&(sc->sbm_txdma));
> > +			sbdma_tx_process(sc,&(sc->sbm_txdma), 0);
> > +#ifdef CONFIG_NETPOLL_TRAP
> > +		       if (netpoll_trap()) {
> > +			       if 
> (test_and_clear_bit(__LINK_STATE_XOFF, &dev->state)) 
> > +				       __netif_schedule(dev);
> > +		       }
> > +#endif
> >  		}
> 
>     This just doesn't make sense. That option is enabled to 
> *prevent* calls to 
> __netif_schedule() -- you can't override it that way. (Well, 
> how it works 
> currently, doesn't make much sense either since it totally 
> breaks the TX queue 
> control -- I was going to post a patch).

I'll admit - this was just copied over from the non-NAPI version we
started with ;-).

Are you saying that the #ifdef test should simply be an #ifndef here?

[I'm working on a revised patch based on feedback from Ralf and others
which removes the Kconfig option for NAPI - it'll just be on, all the
time.]

Thanks,
Mark

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html