netdev - [SC92031]: Fix priv->lock context (was: 2.6.21-rc5-mm4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Apr 2007 21:44:31 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	netdev@...r.kernel.org, "Antonino A. Daplas" <adaplas@....net>,
	Jeff Garzik <jgarzik@...ox.com>
Subject: [SC92031]: Fix priv->lock context (was: 2.6.21-rc5-mm4)

On Thu, Apr 05, 2007 at 02:04:02AM +0000, Andrew Morton wrote:
> 
> This looks like a locking bug in the ipv6 changes in davem's devel tree.
> There are no relevant changes to drivers/net/sc92031.c in rc5-mm4.

Actually, this looks like a latent bug in sc92031.  It's calling
spin_lock in the dev->open function on a lock that's held in BH
context.

[SC92031]: Fix priv->lock context

The spin_lock calls made in dev->open and dev->close must disable
BH since open/close are made in process context.  Conversely, the
call in dev->hard_start_xmit does not need to disable BH since it
is already executing with BH disabled.

Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html