netdev - RE: [PATCH 2/2] NET: Multiqueue network device support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Apr 2007 13:47:58 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<jgarzik@...ox.com>, "cramerj" <cramerj@...el.com>,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>,
	"Leech, Christopher" <christopher.leech@...el.com>
Subject: RE: [PATCH 2/2] NET: Multiqueue network device support.

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net] 
> Sent: Monday, April 09, 2007 1:47 PM
> To: Waskiewicz Jr, Peter P
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; 
> jgarzik@...ox.com; cramerj; Kok, Auke-jan H; Leech, Christopher
> Subject: Re: [PATCH 2/2] NET: Multiqueue network device support.
> 
> From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
> Date: Mon, 9 Apr 2007 13:43:11 -0700
> 
> > True, but the assignment for "dev" above also casts this void * to 
> > struct net_device *:
> > 
> >         dev = (struct net_device *)
> >                 (((long)p + NETDEV_ALIGN_CONST) & 
> ~NETDEV_ALIGN_CONST);
> >         dev->padded = (char *)dev - (char *)p;
> > 
> > Shall I remove my cast?
> 
> I think so.  Casts tend to be red flags during patch review, 
> so don't add them when not necessary and let's remove the 
> unnecessary ones too.

Will do.  On a side note, I don't see my patches landing on vger again.
Did they get munched, or is majordomo lagging a bit?

Thanks,

-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html