lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Apr 2007 18:52:10 +0300 (EEST) From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi> To: Patrick McHardy <kaber@...sh.net> cc: Christoph Hellwig <hch@...radead.org>, netdev@...r.kernel.org, David Miller <davem@...emloft.net> Subject: Re: [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...) On Mon, 16 Apr 2007, Patrick McHardy wrote: > Ilpo Järvinen wrote: > > On Mon, 16 Apr 2007, Patrick McHardy wrote: > > > > [...] It's not clear to me what is really the preferred > > style considering all the variants... [...] > > The preferred style is a newline after variable declarations. Some > (mostly old) code doesn't consistently do that, but in cases where > you add the first local variable you should really add them. Just to make sure... And this holds in all cases, e.g., in 2 lines functions too like tcp_push_pending_frames? Maybe I'm just being too picky or something... :-) -- i.
Powered by blists - more mailing lists