netdev - Re: [Bugme-new] [Bug 8330] New: lmc: copy_to/from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 20 Apr 2007 15:56:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	netdev@...r.kernel.org
Cc:	"bugme-daemon@...nel-bugs.osdl.org" 
	<bugme-daemon@...zilla.kernel.org>, matthias.kaehlcke@...il.com,
	khc@...waw.pl
Subject: Re: [Bugme-new] [Bug 8330] New: lmc: copy_to/from_user cals while
 spinlock is held

On Sun, 15 Apr 2007 14:28:42 -0700
bugme-daemon@...zilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=8330
> 
>            Summary: lmc: copy_to/from_user cals while spinlock is held
>     Kernel Version: 2.6.20
>             Status: NEW
>           Severity: normal
>              Owner: jgarzik@...ox.com
>          Submitter: matthias.kaehlcke@...il.com
> 
> 
> Problem Description:
> 
> the lmc_ioctl() function in drivers/net/wan/lmc/lmc_main.c calls
> copy_from/to_user() while the spinlock sc->lmc_lock is held. AFAIK this should
> not be done as copy_from/to_user() might sleep
> 

urgh.  That function is a study in "what not to do while holding a spinlock".
Including "return without having unlocked it".

It is irreparable.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html