netdev - Re: [patch 05/15] net: tun/tap: fixed hw address handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Apr 2007 01:01:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, linuxkernel@...style.com
Subject: Re: [patch 05/15] net: tun/tap: fixed hw address handling

From: akpm@...ux-foundation.org
Date: Thu, 26 Apr 2007 00:27:24 -0700

> From: Brian Braunstein <linuxkernel@...style.com>
> 
> Fixed tun/tap driver's handling of hw addresses.  The hw address is stored
> in both the net_device.dev_addr and tun.dev_addr fields.  These fields were
> not kept synchronized, and in fact weren't even initialized to the same
> value.  Now during both init and when performing SIOCSIFHWADDR on the tun
> device these values are both updated.  However, if SIOCSIFHWADDR is
> performed on the net device directly (for instance, setting the hw address
> using ifconfig), the tun device does not get updated.  Perhaps the
> tun.dev_addr field should be removed completely at some point, as it is
> redundant and net_device.dev_addr can be used anywhere it is used.
> 
> Signed-off-by: Brian Braunstein <linuxkernel@...style.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html