netdev - Re: [PATCH 2/3] ne: MIPS: Use platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Apr 2007 13:28:18 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
CC:	linux-mips@...ux-mips.org, netdev@...r.kernel.org,
	ralf@...ux-mips.org, sshtylyov@...mvista.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

Atsushi Nemoto wrote:
> On Sat, 28 Apr 2007 11:10:37 -0400, Jeff Garzik <jeff@...zik.org> wrote:
>>>  static unsigned int netcard_portlist[] __initdata = {
>>> -	0x300, 0x280, 0x320, 0x340, 0x360, 0x380, 0
>>> +#if defined(CONFIG_ISA) || defined(CONFIG_M32R)
>>> +	0x300, 0x280, 0x320, 0x340, 0x360, 0x380,
>>> +#endif
>>> +	0
>> This looks a bit strange, and perhaps more difficult to maintain long term.
>>
>> I would suggest creating a NEEDS_PORTLIST cpp macro at the top of ne.c, 
>> to be defined or undefined based on CONFIG_xxx symbols.  Then, down in 
>> the code itself, conditionally include or exclude all portlist related 
>> data tables and code.
>>
>> Sound sane?
> 
> Sure.  Do you mean something like this?

Correct.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html