netdev - Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 30 Apr 2007 00:18:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

From: James Chapman <jchapman@...alix.com>
Date: Mon, 23 Apr 2007 17:01:03 +0100

> [L2TP]: Add PPP-over-L2TP driver core.
> 
> This driver handles only L2TP data frames; control frames are handled
> by a userspace application. It implements L2TP using the PPPoX socket
> family. Data is sent or received using regular socket sendmsg() /
> recvmsg() calls. Kernel parameters of the socket can be read or
> modified using ioctl() or [gs]etsockopt() calls.
> 
> Signed-off-by: James Chapman <jchapman@...alix.com>

I have no major objections to this patch.

It is certainly verbose and could stand a lot of cleanup
and debug code removal, but it's functional and has no
glaring abuses of the networking.

Please fixup patch #2 so I can apply this one.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html