netdev - Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 05 May 2007 13:27:14 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, davem@...emloft.net,
	David Howells <dhowells@...hat.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

On Sat, 2007-05-05 at 13:20 -0400, Trond Myklebust wrote:
> On Sat, 2007-05-05 at 18:44 +0200, Adrian Bunk wrote:
> > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.21-rc7-mm2:
> > >...
> > >  git-net.patch
> > >...
> > >  git trees
> > >...
> > 
> > match_table_t was made "const" and gcc doesn't like "const __initdata":
> 
> Then please revert the "fix" to match_table_t...
> 
> There is no reason for something like the nfsroot parser to be kept in
> memory after the system has booted. That would be code bloat.
> 
> Trond

Alternatively, please change the nfsroot parser to use

        static struct match_token tokens[] __initdata = {

That is in any case cleaner than using a typedef.

Trond

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html