netdev - Re: [PATCH 8/11][TG3]: Add TG3_FLAG_SUPPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 05 May 2007 13:09:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	mchan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH 8/11][TG3]: Add TG3_FLAG_SUPPORT_MSI flag.

From: Jeff Garzik <jeff@...zik.org>
Date: Fri, 04 May 2007 20:38:43 -0400

> Michael Chan wrote:
> > @@ -10404,6 +10400,8 @@ static void __devinit tg3_read_fw_ver(struct tg3 *tp)
> >  	}
> >  }
> >  
> > +static struct pci_dev * __devinit tg3_find_peer(struct tg3 *);
> > +
> >  static int __devinit tg3_get_invariants(struct tg3 *tp)
> >  {
> >  	static struct pci_device_id write_reorder_chipsets[] = {
> 
> 
> Prototypes are better kept at the top of the file, grouped together.  It 
> can sometimes be a pain later on, if they are scattered throughout a big 
> source file like tg3.c.
> 
> ACK the patch's content of course

I disagree with this.  In my drivers I try to keep the forward
declarations as far down in the file as possible, so that functions
are only visible to the stuff that actually needs it.

In any event, even if I agreed with this idea, the tg3.c driver
has not followed that convention and such a switch over
would be a seperate change.

Patch applied, thanks Michael.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html