netdev - Re: [PATCH 06/17] sky2: advanced error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 May 2007 12:05:51 -0500
From:	linas@...tin.ibm.com (Linas Vepstas)
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	Greg KH <greg@...ah.com>, linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: [PATCH 06/17] sky2: advanced error reporting

On Tue, May 08, 2007 at 08:49:55PM -0700, Stephen Hemminger wrote:
> Use the kernel interfaces for advanced error reporting.
> This should be cleaner and clear up errors on boot.

Hmm. I thought that the AER functions would eventually 
be handled by the struct pci_error_handlers callbacks,
so that dev drivers wouldn't actually have code such as

> +		pci_read_config_dword(pdev, pos + PCI_ERR_UNCOR_STATUS, &status);
> +		pci_read_config_dword(pdev, pos + PCI_ERR_UNCOR_SEVER, &mask);

in them. But perhaps I haven't studed what this drivr is trying to 
do; nor have I really kept track of the aer code.

--linas

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html