netdev - Re: [patch 04/13] ppp_generic: fix lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 May 2007 12:09:07 +0200
From:	Jarek Poplawski <jarkao2@...pl>
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, jeff@...zik.org, netdev@...r.kernel.org,
	jura@...ams.com, paulus@...ba.org
Subject: Re: [patch 04/13] ppp_generic: fix lockdep warning

On Mon, May 14, 2007 at 02:18:31AM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@...pl>
> Date: Mon, 14 May 2007 09:28:45 +0200
> 
> > Yes, this is very good idea, and I wonder, why you didn't try
> > this yourself (after my "ignore").
> 
> Because you are a skilled programmer and you might find some
> flaw in my suggestion :-)
> 

Yes, here are some flaws:

if (Dave_M_was_ignored)
	goto not_skilled_programmer;

if (Jarek_P_finds_some_flow)
	goto message_sent;
else
	goto message_sent; /* probably the same */

Cheers,
Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html