lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 May 2007 20:55:47 +1000 From: Herbert Xu <herbert@...dor.apana.org.au> To: auke-jan.h.kok@...el.com (Kok, Auke) Cc: cebbert@...hat.com, netdev@...r.kernel.org Subject: Re: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1 Kok, Auke <auke-jan.h.kok@...el.com> wrote: > >> The source file has four extra lines at the top because of a >> trivial wireless patch, so 898 in that code is really 894 in >> the stock kernel. > > please shared that code then. I've had a look and e1000 is definitely buggy. The problem is that you're calling netif_poll_enable on startup. This is *wrong*. netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a crash like this. So perhaps you should divide e1000_up into two sections, one that is called on both start and restart and another which is only called on restart (i.e., after e1000_down). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists