netdev - Re: [NET] napi: Call __netif_rx_complete in netif_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 May 2007 19:50:07 +0200
From:	Ingo Oeser <netdev@...eo.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [NET] napi: Call __netif_rx_complete in netif_rx_complete

Hi Herbert,

Herbert Xu schrieb:
> [NET] napi: Call __netif_rx_complete in netif_rx_complete
> 
> This patch kills a little bit of code duplication between the two
> variants of netif_rx_complete.

What about making it out of line? 

There is nothing the compiler can optimize away here 
and the code looks bigger than a function call with a single argument.

Maybe even make the callers out of line?

Best regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html