netdev - [PATCH] tcp_probe: __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jun 2007 18:01:41 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	netdev <netdev@...r.kernel.org>
Cc:	davem@...emloft.net
Subject: [PATCH] tcp_probe: __attribute__ string location

From: Randy Dunlap <randy.dunlap@...cle.com>

gcc doesn't like the location of the __attribute__ string here:
net/ipv4/tcp_probe.c:83: warning: empty declaration

so move it to before the function and all is well.

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 net/ipv4/tcp_probe.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2622-rc4.orig/net/ipv4/tcp_probe.c
+++ linux-2622-rc4/net/ipv4/tcp_probe.c
@@ -62,6 +62,7 @@ struct {
  * Print to log with timestamps.
  * FIXME: causes an extra copy
  */
+__attribute__ ((format (printf, 1, 2)))
 static void printl(const char *fmt, ...)
 {
 	va_list args;
@@ -80,7 +81,7 @@ static void printl(const char *fmt, ...)
 
 	kfifo_put(tcpw.fifo, tbuf, len);
 	wake_up(&tcpw.wait);
-} __attribute__ ((format (printf, 1, 2)));
+};
 
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html