[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 06 Jun 2007 12:52:44 -0500
From: wendy xiong <wendyx@...ibm.com>
To: Jeff Garzik <jeff@...zik.org>
Cc: Mithlesh Thukral <mithlesh@...xen.com>, netdev@...r.kernel.org,
amitkale@...xen.com, netxenproj@...syssoft.com, rob@...xen.com
Subject: Re: [PATCH 3/5] NetXen: Add NETXEN prefix to macros
On Sun, 2007-06-03 at 11:50 -0400, Jeff Garzik wrote:
> Mithlesh Thukral wrote:
> > NetXen: Add NETXEN prefix to a macro
> > This patch will add the "NETXEN" prefix to "USER_START" macro.
> >
> > Signed-off by: Wen Xiong <wenxiong@...ibm.com>
> > Signed-off by: Mithlesh Thukral <mithlesh@...xen.com>
> > ---
> >
> > drivers/net/netxen/netxen_nic.h | 4 ++--
> > drivers/net/netxen/netxen_nic_ethtool.c | 2 +-
> > drivers/net/netxen/netxen_nic_hw.c | 4 ++--
> > drivers/net/netxen/netxen_nic_init.c | 4 ++--
> > 4 files changed, 7 insertions(+), 7 deletions(-)
>
> Your patch description is useless. Clearly we know -what- it does,
> simply by reading the patch.
>
> But it does not answer the simple question: why? why is this needed in
> a bug fix Release Candidate series?
Hi Jeff,
When we backported netxen driver to 2.6.9 kernel on ppc, we saw the
compile errors for "USER_START". Because there is another definition for
USER_START which is used by arch/ppc64/mm/hash_utils.c and native.c.
So we like to add NETXEN before USER_START in netxen device driver, then
netxen driver can be compiled correctly in 2.6.9 kernel.
Let me know if you any question for this patch.
Thanks,
wendy Xiong
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists