netdev - Re: [PATCH 3/4] [IPV4]: Add default config support after inetdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jun 2007 22:31:11 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] [IPV4]: Add default config support after inetdev_init

On Mon, Jun 11, 2007 at 02:26:58PM +0200, Patrick McHardy wrote:
> 
> I noticed a few more side-effects from the original change that
> seem to be undesired. Some code assumes that dev->ip_ptr != NULL
> implies existance of IP addresses on the device. For example
> fib_check_nh used to allow to add routes to devices only when a
> in_device is present. We can now add routes without having any
> IP addresses configured, which makes routing choose 0.0.0.0 as
> source and invalidates the assumption of some other code that
> the outgoing device of a packet always has an in_device present
> (like MASQUERADE). fib_sync_up used to skip a nexthop when no
> IP addresses was present on the device, now it will keep it.
> There's probably more, I guess we need to audit all in_dev_get
> calls.

Good catch.  I'll work through them.  Oh yeah I still need to do
the same thing for IPv6 too.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html