lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jun 2007 15:42:39 +0530 From: psr <pradeep.rautela@...il.com> To: "Shani Moideen" <shani.moideen@...ro.com> Cc: jgarzik@...ox.com, akpm@...ux-foundation.org, netdev@...r.kernel.org, kernel-janitors@...ts.osdl.org Subject: Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c On 6/13/07, Shani Moideen <shani.moideen@...ro.com> wrote: > > Replacing alloc_pages(gfp,0) with alloc_page(gfp) > in net/core/pktgen.c > > Signed-off-by: Shani Moideen <shani.moideen@...ro.com> > ---- > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > index b92a322..2600c7f 100644 > --- a/net/core/pktgen.c > +++ b/net/core/pktgen.c > @@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev, > > i = 0; > while (datalen > 0) { > - struct page *page = alloc_pages(GFP_KERNEL, 0); > + struct page *page = alloc_page(GFP_KERNEL); Does this makes any difference anyway? Both are same eventually? What is the rational behind this? Can you please help me understanding this? thanks --pradeep > skb_shinfo(skb)->frags[i].page = page; > skb_shinfo(skb)->frags[i].page_offset = 0; > skb_shinfo(skb)->frags[i].size = > @@ -2762,7 +2762,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev, > > i = 0; > while (datalen > 0) { > - struct page *page = alloc_pages(GFP_KERNEL, 0); > + struct page *page = alloc_page(GFP_KERNEL); > skb_shinfo(skb)->frags[i].page = page; > skb_shinfo(skb)->frags[i].page_offset = 0; > skb_shinfo(skb)->frags[i].size = > > -- > Shani > _______________________________________________ > Kernel-janitors mailing list > Kernel-janitors@...ts.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists