netdev - Re: [PATCH 0/15] spidernet driver bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jun 2007 11:33:16 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Linas Vepstas <linas@...tin.ibm.com>,
	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	cbe-oss-dev@...abs.org
Subject: Re: [PATCH 0/15] spidernet driver bug fixes

On Tue, 2007-06-12 at 19:00 -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> > On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote:
> >> On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote:
> >>> On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael Ellerman wrote:
> >>>> On Thu, 2007-06-07 at 14:17 -0500, Linas Vepstas wrote:
> >>>>> The major bug fixes are: 
> >>>> I realise it's late, but shouldn't "major bugfixes" be going into 22 ?
> >>> Yeah, I suppose, I admit I've lost track of the process. 
> >> You need to order your bug fixes first in the queue. 
> > 
> > OK, here are the patches, re-ordered. There is a different number
> > than last time, as I threw out one, merged one, and got cold feet
> > on a third one.  They still pass the tests.
> > 
> > The first five patches focus on three serious bugs, fixing crashes or
> > hangs.
> > 
> > -- patch 1 -- kernel crash when ifdown while receiving packets.
> > -- patch 2,3,4 -- device driver deadlocks on "RX ram full" mesgs.
> >                   (kernel stays up, ifdown/up clear the problem).
> > -- patch 5 -- misconfigured TX interrupts results in 3x-4x per
> >               degradation for small packets.
> > 
> > -- patch 6 -- rx stats may be mangled
> > -- patch 7 -- hw checksum sometimes breaks ipv6 operation
> > 
> > -- patches 8-15 -- misc tweaks, and documentation.
> > 
> > 
> > I re-ran my stress tests with patches 1-7 applied; they pass.
> 
> This is a bit frustrating, because this includes many patches that you 
> ALREADY told me to queue for 2.6.23, which I did, in 
> netdev-2.6.git#upstream.

Linas posted the patches, I responded querying whether the bug fixes
should go into 2.6.22, and then you told him "you need to order your bug
fixes first in the queue". Which seemed pretty clear to me that you'd
wait for the reordered series.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)