netdev - Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jun 2007 14:11:31 +0200
From:	Michael Buesch <mb@...sch.de>
To:	Keir Fraser <Keir.Fraser@...cam.ac.uk>
Cc:	Kieran Mansley <kmansley@...arflare.com>,
	xen-devel@...ts.xensource.com, netdev@...r.kernel.org,
	herbert@...dor.apana.org.au
Subject: Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules

On Friday 15 June 2007 13:26:03 Keir Fraser wrote:
> On 15/6/07 11:46, "Kieran Mansley" <kmansley@...arflare.com> wrote:
> 
> > This is a repost of some earlier patches to the xen-devel mailing list,
> > with a number of changes thanks to some useful suggestions from others.
> 
> The coding style needs fixing in various ways.
> 
> Hard tabs need to be used, no spaces inside brackets, but should include
> spaces between if/while/for and bracket, and bracket and brace:
>     if (foo) {
> Not
>     if( foo ){
>     if(foo ) {
> Or various other possibilities.
> 
> No use of the following please:
> If (foo) return 1; else return 0;
> Is clearer as:
> Return foo;

But it's not the same.
	return !!foo;
would be the same. And yes, it does matter:

int x(void)
{
	unsigned long long v = 0xFF0000000000ULL;
	/*foo*/
	return v;
}

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html