netdev - Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2007 22:28:46 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, jeff@...zik.org,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>, hadi@...erus.ca
Subject: Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware
 support API

Waskiewicz Jr, Peter P wrote:
>
>>>  /* Functions used for multicast support */ diff --git 
>>> a/include/linux/skbuff.h b/include/linux/skbuff.h index 
>>> e7367c7..8bcd870 100644
>>> --- a/include/linux/skbuff.h
>>> +++ b/include/linux/skbuff.h
>>> @@ -215,6 +215,7 @@ typedef unsigned char *sk_buff_data_t;
>>>   *	@pkt_type: Packet class
>>>   *	@fclone: skbuff clone status
>>>   *	@ip_summed: Driver fed us an IP checksum
>>> + *	@queue_mapping: Queue mapping for multiqueue devices
>>>   *	@priority: Packet queueing priority
>>>   *	@users: User count - see {datagram,tcp}.c
>>>   *	@protocol: Packet protocol from driver
>>> @@ -269,6 +270,7 @@ struct sk_buff {
>>>  			__u16	csum_offset;
>>>  		};
>>>  	};
>>> +	__u16			queue_mapping;
>>>   
>>>       
>> We have a 4 byte hole on 64 bit after iif where this would fit in.
>>     
>
> I'll move the variable.  Thanks for this!
>   

Or maybe move iif down to queue_mapping so both are near the
queueing related stuff.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html