netdev - Re: [NET_SCHED 03/04]: sch_htb: use generic estimator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Jun 2007 23:22:06 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Ranjit Manomohan <ranjitm@...gle.com>
CC:	davem@...emloft.net, devik@....cz, netdev@...r.kernel.org
Subject: Re: [NET_SCHED 03/04]: sch_htb: use generic estimator

Ranjit Manomohan wrote:
> On 6/19/07, Patrick McHardy <kaber@...sh.net> wrote:
> 
>> [NET_SCHED]: sch_htb: use generic estimator
>>
>> Use the generic estimator instead of reimplementing (parts of) it.
>> For compatibility always create a default estimator for new classes.
>>
>>
>> +               gen_new_estimator(&cl->bstats, &cl->rate_est,
>> +                                 &sch->dev->queue_lock, &est.rta);
> 
> 
> Probably need to change the last parameter to
> tca[TCA_RATE-1]?:&est.rta to check if estimator params are specified
> at creation time?


Good point, thanks for catching this.


View attachment "03.diff" of type "text/x-diff" (6214 bytes)