netdev - Re: [PATCH -mm 7/9] netconsole: Support multiple logging targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 Jul 2007 01:16:17 +0530 (IST)
From:	Satyam Sharma <ssatyam@....iitk.ac.in>
To:	KII Keiichi <k-keiichi@...jp.nec.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>,
	Joel Becker <joel.becker@...cle.com>,
	Matt Mackall <mpm@...enic.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH -mm 7/9] netconsole: Support multiple logging targets

Hi,

On Sun, 8 Jul 2007, KII Keiichi wrote:
> Hi Satyam,
> 
> The following comments aren't essential.
> 
> >  	if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
> >  	      event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
> > -	      	goto done;
> > +		goto done;
> 
> The above diff lines are extra.

Eek, looks like some whitespace correction leaked in here. I'll take care
not to produce the bad whitespace in the first place the first time this
line comes in.

> > +	spin_lock_irqsave(&target_list_lock, flags);
> > +	list_for_each_entry(nt, &target_list, list) {
> > +		if (nt->np.dev == dev) {
> > +			switch (event) {
> > +			case NETDEV_UP:
> > +			case NETDEV_DOWN:
> > +				nt->dev_status = net_dev_is_up(nt->np.dev);
> > +				break;
> > +
> > +			case NETDEV_CHANGEADDR:
> > +				memcpy(nt->np.local_mac, dev->dev_addr, ETH_ALEN);
> 
> The above line is over 80 characters.

Hmm, yes, but only by 2 columns. It's a simple and readable line
in its present form, so I'm not sure I'd want to be an extremist
and cut it into two ...

Satyam
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html