netdev - Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [1/8]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Jul 2007 09:38:52 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	"Steven J. Hill" <sjhill@...litydiluted.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Merge GT/MV642xx Support into MV643xx Driver [1/8]

On Wed, Jul 18, 2007 at 11:47:54PM -0500, Steven J. Hill wrote:
> This first patch 642xx #defines to the 'include/linux/mv643xx.h' file.

I don't think register names should change based on ifefs.  Please make
sure both variants can be supported at runtime.  While mips might not
support different controllers in one binary powerpc certainly does.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html