lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Jul 2007 15:36:50 +0200 From: Adrian Bunk <bunk@...sta.de> To: Andrew Morton <akpm@...ux-foundation.org>, Auke Kok <auke-jan.h.kok@...el.com>, jgarzik@...ox.com Cc: linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org Subject: [-mm patch] one e1000 driver should be enough for everyone On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote: >... > Changes since 2.6.22-rc6-mm1: >... > git-e1000new.patch >... > git trees >... Both e1000 drivers compiled into the kernel resulted in the following compile error: <-- snip --> ... LD drivers/net/built-in.o drivers/net/e1000/built-in.o: In function `e1000_read_mac_addr': (.text+0xb9f2): multiple definition of `e1000_read_mac_addr' drivers/net/e1000new/built-in.o:(.text+0x821a): first defined here drivers/net/e1000/built-in.o: In function `e1000_phy_setup_autoneg': (.text+0x8799): multiple definition of `e1000_phy_setup_autoneg' drivers/net/e1000new/built-in.o:(.text+0xa9bd): first defined here ... make[3]: *** [drivers/net/built-in.o] Error 1 <-- snip --> Signed-off-by: Adrian Bunk <bunk@...sta.de> --- BTW: Unless I'm misunderstanding anything, the new driver should support a superset of what the old driver supported. Therefore, it would be good if the final merge into Linus' tree will do an rm -r drivers/net/e1000 mv drivers/net/e1000new drivers/net/e1000 --- linux-2.6.23-rc1-mm1/drivers/net/Kconfig.old 2007-07-25 15:06:13.000000000 +0200 +++ linux-2.6.23-rc1-mm1/drivers/net/Kconfig 2007-07-25 15:09:59.000000000 +0200 @@ -2036,7 +2036,7 @@ config E1000 tristate "Intel(R) PRO/1000 Gigabit Ethernet support" - depends on PCI + depends on PCI && E1000NEW=n ---help--- This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists