lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jul 2007 21:56:30 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: paulmck@...ux.vnet.ibm.com Cc: Stephen Hemminger <shemminger@...ux-foundation.org>, Adrian Bunk <bunk@...sta.de>, Robert Olsson <Robert.Olsson@...a.slu.se>, Ingo Molnar <mingo@...e.hu>, Josh Triplett <josh@...nel.org>, netdev@...r.kernel.org Subject: Re: [RFC] fib_trie: whitespace cleanup On Thu, 26 Jul 2007 08:44:21 -0700 "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote: > On Thu, Jul 26, 2007 at 11:49:42AM +0100, Stephen Hemminger wrote: > > Whitespace cleanup run code through lindent then cleanup results. > > Applys after other two patches. > > > > --- a/net/ipv4/fib_trie.c 2007-07-26 10:17:21.000000000 +0100 > > +++ b/net/ipv4/fib_trie.c 2007-07-26 11:47:52.000000000 +0100 > > @@ -156,7 +156,8 @@ struct trie { > > }; > > > > static void put_child(struct trie *t, struct tnode *tn, int i, struct node *n); > > -static void tnode_put_child_reorg(struct tnode *tn, int i, struct node *n, int wasfull); > > +static void tnode_put_child_reorg(struct tnode *tn, int i, struct node *n, > > + int wasfull); > > static struct node *resize(struct trie *t, struct tnode *tn); > > static struct tnode *inflate(struct trie *t, struct tnode *tn); > > static struct tnode *halve(struct trie *t, struct tnode *tn); > > @@ -167,13 +168,12 @@ static struct trie *trie_local = NULL, * > > > > static inline struct tnode *node_parent(struct node *node) > > { > > - return rcu_dereference((struct tnode *) (node->parent & ~NODE_TYPE_MASK)); > > + return rcu_dereference((struct tnode *)(node->parent & ~NODE_TYPE_MASK)); > > The potential issue is applying rcu_dereference() to an rvalue > as opposed to an lvalue. So how about the following? > I did this: static inline struct tnode *node_parent(struct node *node) { struct tnode *ret; ret = (struct tnode *)(node->parent & ~NODE_TYPE_MASK); return rcu_dereference(ret); } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists