lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 31 Jul 2007 17:22:35 +0300
From:	"Michael S. Tsirkin" <mst@....mellanox.co.il>
To:	Or Gerlitz <ogerlitz@...taire.com>
Cc:	"Michael S. Tsirkin" <mst@....mellanox.co.il>,
	netdev@...r.kernel.org, Roland Dreier <rdreier@...co.com>,
	fubar@...ibm.com, general@...ts.openfabrics.org,
	davem@...emloft.net
Subject: Re: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for	the
	bonding driver

> Quoting Or Gerlitz <ogerlitz@...taire.com>:
> Subject: Re: Re: Re: [PATCH V3 0/7] net/bonding: ADD IPoIB support for?the bonding driver
> 
> Michael S. Tsirkin wrote:
> >Maybe we could use hard_header_cache/header_cache_update methods instead of
> >neighbour cleanup calls.
> 
> >To do this, it is possible that we'll have to switch from storing pointers
> >inside the neighbour to keeping an index there, but I expect the
> >performance impact to be minimal.
> >
> >As a result, bonding would not have to copy pointers into ipoib module
> >and module removal would get fixed.
> 
> To be precise, bonding will copy all the symbols it copies today from 
> the slave module (ipoib),
> see bond_setup_by_slave() in patch 3/7, except 
> for the neighbour cleanup callback which is copied through coping the 
> neigh_setup function.

Not really.
This copying of symbols is something that you added, isn't it?
So with this approach, it won't be needed.

It's always wrong to copy symbols from another module without
referencing it.
-- 
MST
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists