netdev - Re: net driver error accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Aug 2007 16:38:09 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	netdev@...r.kernel.org, Natalie Protasevich <protasnb@...il.com>
Subject: Re: net driver error accounting

Andrew Morton wrote:
> Looking at http://bugzilla.kernel.org/show_bug.cgi?id=8106
> 
> Guys, could we please have a ruling here?
> 
> When a net driver encounters a tx_fifo_error, should this also contribute
> to the tx_error count, or should it not?

For each TX error, (a) tx_error is incremented and (b) a more-specific 
TX error stat is also potentially incremented.  So, yes, tx_error 
accumulates.

See cp_tx() in 8139cp.


> More generally, should netdev drivers accumulate all the detailed
> rx_errors into net_device_stats.rx_errors in real time, or should they not?

For each RX error, (a) rx_error is incremented and (b) a more-specific 
RX error stat is also potentially incremented.  So, yes, rx_error 
accumulates.

See cp_rx_err_acct() in 8139cp.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html